Wire passkey autofill to UI #13051
Draft
Wire passkey autofill to UI #13051
+558
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (25)Checkmarx found the following issues in this Pull Request Fixed Issues (563)Great job! The following issues were fixed in this Pull Request
|
coroiu
reviewed
Jan 24, 2025
apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts
Show resolved
Hide resolved
apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts
Outdated
Show resolved
Hide resolved
apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts
Outdated
Show resolved
Hide resolved
abergs
commented
Feb 12, 2025
| //allowedCredentials: requestParameters.allowedCredentials, | ||
| //extensionInput: requestParameters.extensionInput, | ||
| clientDataHash: requestParameters.clientDataHash, | ||
| userVerification: userVerification |
There was a problem hiding this comment.
@coroiu The PasskeyAssertionRequest rust type probably needs to be tweaked or a new type introduced to support this flow. Since you did the OG work on this, do you have time to look into it?
There was a problem hiding this comment.
Actually Dani did this specific part, I wrote the Obj-C code, but we can all help you out (including @coltonhurst) :) I'll take a quick look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Wire the FIDO2 autofill integration with the UI.
TODO:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes